From 02fd2fc7b7e5177f8254b5333e709f4abbfd4dc9 Mon Sep 17 00:00:00 2001
From: Dan Fandrich <danf@mageia.org>
Date: Fri, 16 Feb 2024 17:31:50 -0800
Subject: Allow subversion and root as senders in *-commit lists

When subversion update messages were changed to come from a new address
in commit f3f49a26, not all the mailing lists there were send to were
updated to accept the new sender. This change whitelists it for all the
remaining subversion destination lists. It also adds root@mageia.org to
some lists, which were likely missing some other automated messages.
---
 deployment/lists/manifests/init.pp              | 14 ++++++++------
 deployment/repositories/manifests/subversion.pp |  5 +++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/deployment/lists/manifests/init.pp b/deployment/lists/manifests/init.pp
index 6b151ec4..d54baa58 100755
--- a/deployment/lists/manifests/init.pp
+++ b/deployment/lists/manifests/init.pp
@@ -18,7 +18,7 @@ class lists {
     sympa::list::announce {'atelier-commits':
         subject      => 'Commits on atelier repositories (Artwork, Web, etc ...)',
         reply_to     => "atelier-discuss@ml.${::domain}",
-        sender_email => [ "root@${::domain}" ],
+        sender_email => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics       => 'atelier',
     }
 
@@ -78,6 +78,8 @@ class lists {
         sender_email      => [
             'r2d2@vargas.calenco.com',
             "blog@${::domain}",
+            "root@${::domain}",
+            "subversion_noreply@ml.${::domain}",
             ],
         topics            => 'i18n',
     }
@@ -236,7 +238,7 @@ class lists {
     sympa::list::announce {'qa-commits':
         subject      => 'Update advisories commits',
         reply_to     => "qa-discuss@ml.${::domain}",
-        sender_email => [ "root@${::domain}" ],
+        sender_email => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics       => 'qa',
     }
 
@@ -281,7 +283,7 @@ class lists {
     sympa::list::announce {'sysadmin-commits':
         subject      => 'Commits on sysadmin repository',
         reply_to     => "sysadmin-discuss@ml.${::domain}",
-        sender_email => [ "root@${::domain}" ],
+        sender_email => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics       => 'sysadmin',
     }
 
@@ -307,7 +309,7 @@ class lists {
     sympa::list::announce { 'soft-commits':
         subject      => 'Commits on soft repository',
         reply_to     => "dev@ml.${::domain}",
-        sender_email => [ "root@${::domain}" ],
+        sender_email => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics       => 'developers',
     }
 
@@ -349,7 +351,7 @@ class lists {
     sympa::list::announce { 'board-commits':
         subject               => 'Commits on Mageia.Org status and organisation documents',
         reply_to              => "board-public@ml.${::domain}",
-        sender_email          => [ "root@${::domain}" ],
+        sender_email          => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics                => 'governance',
         subscriber_ldap_group => 'mga-board',
     }
@@ -369,7 +371,7 @@ class lists {
     sympa::list::announce {'treasurer-commits':
         subject      => 'Commits on Mageia.Org association treasurer repository',
         reply_to     => "treasurer@${::domain}",
-        sender_email => [ "root@${::domain}" ],
+        sender_email => [ "root@${::domain}", "subversion_noreply@ml.${::domain}" ],
         topics       => 'governance',
     }
 
diff --git a/deployment/repositories/manifests/subversion.pp b/deployment/repositories/manifests/subversion.pp
index f7485e8f..742efe67 100644
--- a/deployment/repositories/manifests/subversion.pp
+++ b/deployment/repositories/manifests/subversion.pp
@@ -1,5 +1,10 @@
 class repositories::subversion {
 
+    # Be sure that any mailing list found in commit_mail here whitelists
+    # "subversion_noreply@ml.mageia.org" as a sender by adding it to
+    # sender_email in its sympa::list::X configuration in
+    # deployment/lists/manifests/init.pp
+
     subversion::repository { '/svn/adm/':
         group        => 'mga-sysadmin',
         commit_mail  => ["sysadmin-commits@ml.${::domain}"],
-- 
cgit v1.2.1