aboutsummaryrefslogtreecommitdiffstats
path: root/editmilestones.cgi
diff options
context:
space:
mode:
authormkanat%kerio.com <>2005-03-09 08:26:38 +0000
committermkanat%kerio.com <>2005-03-09 08:26:38 +0000
commit0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a (patch)
tree93f5ab09d20a212b8ba499e2cf59756aaad3b902 /editmilestones.cgi
parent5b1b54e9b96da06b6802f79108a20080f7f93f18 (diff)
downloadbugs-0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a.tar
bugs-0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a.tar.gz
bugs-0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a.tar.bz2
bugs-0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a.tar.xz
bugs-0b7d9e7f772ee107d0cb1816d6c5cb679ae6e01a.zip
Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk
Diffstat (limited to 'editmilestones.cgi')
-rwxr-xr-xeditmilestones.cgi12
1 files changed, 0 insertions, 12 deletions
diff --git a/editmilestones.cgi b/editmilestones.cgi
index 7317e7220..85bcae8d3 100755
--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -60,14 +60,12 @@ sub CheckProduct ($)
# do we have a product?
unless ($product) {
ThrowUserError('product_not_specified');
- exit;
}
# Does it exist in the DB?
unless (TestProduct $product) {
ThrowUserError('product_doesnt_exist',
{'product' => $product});
- exit;
}
}
@@ -104,7 +102,6 @@ sub CheckMilestone ($$)
# do we have the milestone and product combination?
unless ($milestone) {
ThrowUserError('milestone_not_specified');
- exit;
}
CheckProduct($product);
@@ -113,7 +110,6 @@ sub CheckMilestone ($$)
ThrowUserError('milestone_not_valid',
{'product' => $product,
'milestone' => $milestone});
- exit;
}
}
@@ -254,13 +250,11 @@ if ($action eq 'new') {
unless ($milestone) {
ThrowUserError('milestone_blank_name',
{'name' => $milestone});
- exit;
}
if (length($milestone) > 20) {
ThrowUserError('milestone_name_too_long',
{'name' => $milestone});
- exit;
}
# Need to store in case detaint_natural() clears the sortkey
@@ -269,13 +263,11 @@ if ($action eq 'new') {
ThrowUserError('milestone_sortkey_invalid',
{'name' => $milestone,
'sortkey' => $stored_sortkey});
- exit;
}
if (TestMilestone($product, $milestone)) {
ThrowUserError('milestone_already_exists',
{'name' => $milestone,
'product' => $product});
- exit;
}
# Add the new milestone
@@ -492,7 +484,6 @@ if ($action eq 'update') {
if (length($milestone) > 20) {
ThrowUserError('milestone_name_too_long',
{'name' => $milestone});
- exit;
}
my $dbh = Bugzilla->dbh;
@@ -509,7 +500,6 @@ if ($action eq 'update') {
ThrowUserError('milestone_sortkey_invalid',
{'name' => $milestone,
'sortkey' => $stored_sortkey});
- exit;
}
trick_taint($milestoneold);
@@ -530,13 +520,11 @@ if ($action eq 'update') {
if ($milestone ne $milestoneold) {
unless ($milestone) {
ThrowUserError('milestone_blank_name');
- exit;
}
if (TestMilestone($product, $milestone)) {
ThrowUserError('milestone_already_exists',
{'name' => $milestone,
'product' => $product});
- exit;
}
trick_taint($milestone);